semios/semi-libc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

use the correct stat structure in the fstat path

Browse Source 
commit 01ae3fc6d4 modified fstatat to
translate the kernel's struct stat ("kstat") into the libc struct stat.
To do this, it created a local kstat object, and copied its contents
into the user-provided object.

However, the commit neglected to update the fstat compatibility path and
its fallbacks. They continued to pass the user-supplied object to the
kernel, later overwiting it with the uninitialized memory in the local
temporary.
This commit is contained in:
Samuel Holland
2019-07-21 00:58:10 -04:00
committed by Rich Felker
parent e53a91da58
commit 0ce49d0a30
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/stat/fstatat.c
+4 -4
View File
@@ -67,16 +67,16 @@ static int fstatat_kstat(int fd, const char *restrict path, struct stat *restric
struct kstat kst;
if (flag==AT_EMPTY_PATH && fd>=0 && !*path) {
ret = __syscall(SYS_fstat, fd, st);
ret = __syscall(SYS_fstat, fd, &kst);
if (ret==-EBADF && __syscall(SYS_fcntl, fd, F_GETFD)>=0) {
ret = __syscall(SYS_fstatat, fd, path, st, flag);
ret = __syscall(SYS_fstatat, fd, path, &kst, flag);
if (ret==-EINVAL) {
char buf[15+3*sizeof(int)];
__procfdname(buf, fd);
#ifdef SYS_stat
ret = __syscall(SYS_stat, buf, st);
ret = __syscall(SYS_stat, buf, &kst);
#else
ret = __syscall(SYS_fstatat, AT_FDCWD, buf, st, 0);
ret = __syscall(SYS_fstatat, AT_FDCWD, buf, &kst, 0);
#endif
}
}