Gabriel RavierandRich Felker
07616721f1
As a result of using simple subtraction to implement the return values for wcscmp and wcsncmp, integer overflow can occur (producing undefined behavior, and in practice, a wrong comparison result). This does not occur for meaningful character values (21-bit range) but the functions are specified to work on arbitrary wchar_t arrays. This patch replaces the subtraction with a little bit of code that orders the characters correctly, returning -1 if the character from the first string is smaller than the one from the second, 0 if they are equal and 1 if the character from the first string is larger than the one from the second.
8 lines
142 B
C
8 lines
142 B
C
#include <wchar.h>
|
|
|
|
int wcscmp(const wchar_t *l, const wchar_t *r)
|
|
{
|
|
for (; *l==*r && *l && *r; l++, r++);
|
|
return *l < *r ? -1 : *l > *r;
|
|
}
|