fix getgrouplist when nscd reports an empty list
commit 500c6886c6 broke this by fixing
the behavior of fread to conform to the C standard; getgroupslist was
assuming the old behavior, that a request to read 1 member of length 0
would return 1, not 0.
This commit is contained in:
@@ -31,7 +31,8 @@ int getgrouplist(const char *user, gid_t gid, gid_t *groups, int *ngroups)
|
||||
if (resp[INITGRFOUND]) {
|
||||
nscdbuf = calloc(resp[INITGRNGRPS], sizeof(uint32_t));
|
||||
if (!nscdbuf) goto cleanup;
|
||||
if (!fread(nscdbuf, sizeof(*nscdbuf)*resp[INITGRNGRPS], 1, f)) {
|
||||
size_t nbytes = sizeof(*nscdbuf)*resp[INITGRNGRPS];
|
||||
if (nbytes && !fread(nscdbuf, nbytes, 1, f)) {
|
||||
if (!ferror(f)) errno = EIO;
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user